Update Gemfile: CocoaPods 1.16.2 and xcodeproj 1.27.0 #181
Update Gemfile: CocoaPods 1.16.2 and xcodeproj 1.27.0 #181ribamarsantos wants to merge 4 commits intoreact-native-community:mainfrom
Conversation
|
I'm unsure we want to merge this, unless we have a strong reason to restrict the cocoapods version |
|
If not merging, you may want to at least do something like |
@cortinico @cipolleschi |
|
|
||
| # Exclude problematic versions of cocoapods and activesupport that causes build failures. | ||
| gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1' | ||
| gem 'cocoapods', '>=1.16.2' |
There was a problem hiding this comment.
why this? Can't we keep the previous setups? Otherwise we are forcing everyone to use at least 1.16.2. We try to be as flexible as possible with cocoapods.
| gem 'cocoapods', '>=1.16.2' | ||
| gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' | ||
| gem 'xcodeproj', '< 1.26.0' | ||
| gem 'xcodeproj', '>=1.27.0' |
There was a problem hiding this comment.
if only 1.26.0 was broken, can we replace this with != 1.26.0 instead?
There was a problem hiding this comment.
The main motivation to bump the min xcode proj version to >= 1.27 was to be compatible with the most updated cocoapods 1.16.2.
https://rubygems.org/gems/cocoapods.
That been said, What would be the reason to keep older cocoapods / xcodeproj compatible version?
Summary:
This PR updates the template's Gemfile dependencies:
>= 1.13to1.16.2< 1.26.0to1.27.0References:
Changelog:
[IOS][CHANGED] - Update Gemfile: CocoaPods 1.16.2 and xcodeproj 1.27.0
Test Plan: